ci: Add explicit permissions to workflows - #14
Merged
Conversation
Every workflow lacking a `permissions:` block inherits the repository default for GITHUB_TOKEN, which is currently `write` across the org. This grants linters and test workflows push access they never use. Adds a minimal top-level block to each workflow that had none, with elevated scopes only where demonstrably required. Workflows with existing workflow- or job-level permissions are untouched. Prerequisite for switching the org default workflow permissions to read-only. Claude-Session: https://claude.ai/code/session_01Rg3UBFSnmKMPQLNpNKkn8d
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 4 4
Lines 2365 2365
=======================================
Hits 2085 2085
Misses 280 280 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
📊 Benchmark ComparisonClick to expand benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every workflow lacking a
permissions:block inherits the repository default forGITHUB_TOKEN, which is currently write across the org. That grants linters and test workflows push access they never use.This adds a minimal top-level block to each workflow that had none:
contents: readfor linters, tests, and workflows that authenticate to external services with their own credentialsWorkflows that already declare workflow- or job-level permissions are untouched. Pure additions, no deletions.
This is a prerequisite for switching the org default workflow permissions to read-only — flipping that setting first would break the workflows that currently rely on implicit write.
Found via GitHub's Code Security assessment ("Workflow does not contain permissions", Medium, 35 findings), then audited across all non-archived, non-fork repos.
https://claude.ai/code/session_01Rg3UBFSnmKMPQLNpNKkn8d